-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit auto documentation generation with sphinx on RTD #871
Conversation
@benhoyt recently went through this with |
The changelog is not correctly formatted. I made some changes in this PR cderici#2 R2GO when merged. |
Fix language and changelog
/merge |
@cderici Yeah, I brought my Sphinx config up to date in this recent commit. In particular:
It's worth taking a look at that PR and perhaps doing something similar. I'd also recommend bringing your Sphinx version up to at least 6.x if possible (I had some issues with the latest, 7.x). Another thing. It looks like your Makefile
This messes up the dev's machine and makes it harder to iterate, remove deps, etc. I'd strongly recommend using Tox for this (you are already using Tox in this repo, so it should be easy) and adding a |
#899 #### Description This is a follow up on #871 , attempting to have stable green RTD builds for generating the pylibjuju docs. - It adds a tox environment to run the `sphinx-build` locally rather then doing it in the main dev environment. - It adds a new `.readthedocs.yaml` configuration file (which will be required it looks like by Sep 2023) #### Notes & Discussion After the RTD side is stabilized, the actual docs will be revised to keep up-to-date docs for pylibjuju.
Description
This is the first step to revive the auto doc generation (that hasn't been touched for more than 4 years now), so we can get that rolling whenever we land a PR or make a release the docs will be generated and published on ReadTheDocs. The infrastructure is working (i.e. RTD seems to be picking it up), we just need to fix the sphinx build there that's been failing for a long time https://readthedocs.org/projects/python-libjuju/builds/18115299/
I'm not entirely sure yet how to debug the build process on the RTD, however, this change updates and fixes the sphinx setup in the
docs
, so we can runmake html
and actually be able to render the docs. The rest is to be figured out.QA Steps
Notes & Discussion
python3-sphinxcontrib-asyncio
.juju/client/
. For example, check out the_definitions
module here