[JUJU-1705] Make sure the action status is correctly set #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanmanuel-tirado
approved these changes
Oct 21, 2022
|
first glance shows this works for the very simple test i proposed in #719 |
addyess
reviewed
Oct 21, 2022
Co-authored-by: Adam Dyess <[email protected]>
cderici
force-pushed
the
fix-unit-action-run-status
branch
from
340b6a0 to
83519c6
Compare
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the way we set the status of an action that's ran on a unit. Previously only the
action.outputwas being returned and the actual status of the action was being retrieved from theself.data[](as the Action object is a modelEntity), which is not reliable at the moment. This PR changes it to get it directly from the Action object returned by the Juju API when the action completes (with eithercompletedorfailed) status. So it should be completely accurate all the time.Fixes #719
QA Steps
Following should pass %100.