Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUJU-1984] Update facade schemas for juju 3.0-rc1-2 #745

Merged
merged 5 commits into from
Oct 18, 2022

Conversation

cderici
Copy link
Contributor

@cderici cderici commented Oct 17, 2022

Description

This PR updates the facade schema with the latest juju head (develop) and rebuilds the clients etc. This is mostly internal change to bring the libjuju up to date with the most recent changes in juju.

Just as a reference for the future, I'll note here all the versions that are bumped and started to be supported by libjuju:

Application : 15
Charms : 5
Client : 6
MachineManager : 8, 9
Resources : 3
SSHClient : 4
Subnets : 5
AllWatcher : 3
AllModelWatcher : 4

Two new facades are added:

CAASFirewallerSidecar
SecretsTriggerWatcher

QA Steps

Bootstrap with the latest juju on lxd or microk8s and try to run:

application = await model.deploy(
            'parca-k8s,
            application_name='parca',
            trust=True,
            channel='edge',
        )

All (except the known intermittently failing) CI tests need to pass. (The juju latest edge test is failing for some reason, though it's about the jenkins job, not juju/libjuju)

Notes & Discussion

Note that, this only changes the clients for the 3.0 track. The "old" clients, the ones we keep for the 2.9 track are untouched, and it should work the same.

@cderici
Copy link
Contributor Author

cderici commented Oct 17, 2022

Maybe @jnsgruk can help QA this too, as this change should fix this on parca.

@juanmanuel-tirado
Copy link
Contributor

I can confirm that parca-k8s can be deployed with these changes.

Copy link
Contributor

@juanmanuel-tirado juanmanuel-tirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@juanmanuel-tirado
Copy link
Contributor

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants