[JUJU-1671] Charmhub url from model config #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderici
force-pushed
the
charmhub-url-from-model-config
branch
from
e5885f1 to
ffd8e17
Compare
|
/build |
jack-w-shaw
reviewed
Sep 2, 2022
| url = "https://api.snapcraft.io/v2/charms/info/{}?fields=default-release.revision.subordinate".format(charm_name) | ||
| model_conf = await self.model.get_config() | ||
| charmhub_url = model_conf['charmhub-url'] | ||
| url = "{}/v2/charms/info/{}?fields=default-release.revision.subordinate".format(charmhub_url.value, charm_name) |
There was a problem hiding this comment.
Now that we've dropped Python 3.5 support we can use fstrings right?
There was a problem hiding this comment.
Yeah I agree 👍 we should probably turn all the formattings into fstrings at some point
|
I think there's something going on in the tests, none of them is finished, it's more than likely about this change, it's blocking for some reason. Will investigate 👍 |
|
/build |
|
/merge |
jujubot
added a commit
that referenced
this pull request
Oct 6, 2022
#739 ## What's Changed * Model name can now be accessed through model.name by @jack-w-shaw in #702 * [JUJU-1593] Fix `unit.run()` and update the old client codes by @cderici in #710 * Add py.typed marker by @sed-i in #709 * [JUJU-1664] Add force, no-wait, destroy-storage params to app.destroy by @cderici in #714 * snapcraft.io access should use https requests by @addyess in #715 * [JUJU-1680] Add issue and PR templates by @cderici in #718 * [JUJU-1681] Add --attach-storage parameter to model.deploy by @cderici in #720 * [JUJU-1706] Allow waiting for `wait_for_exact_units=0` by @cderici in #723 * [JUJU-1663] Drop Python 3.5 support from python-libjuju by @cderici in #722 * [JUJU-1671] Charmhub url from model config by @cderici in #724 * [JUJU-1733] Revisit unitrun example by @cderici in #725 * [JUJU-1800] Revise the `application.upgrade_charm()` (refresh) by @cderici in #729 * [JUJU-1893] Revisit `charmhub.info()` by @cderici in #737 [JUJU-1593]: https://warthogs.atlassian.net/browse/JUJU-1593?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1664]: https://warthogs.atlassian.net/browse/JUJU-1664?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1680]: https://warthogs.atlassian.net/browse/JUJU-1680?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1681]: https://warthogs.atlassian.net/browse/JUJU-1681?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1706]: https://warthogs.atlassian.net/browse/JUJU-1706?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1663]: https://warthogs.atlassian.net/browse/JUJU-1663?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1671]: https://warthogs.atlassian.net/browse/JUJU-1671?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, the api host address for the charmhub was hard-coded. This change allows fetching the api address from the model config.
QA Steps