Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUJU-1172] Visiting the pylibjuju CI #681

Merged
merged 5 commits into from
Jun 9, 2022
Merged

Conversation

cderici
Copy link
Contributor

@cderici cderici commented May 31, 2022

Description

Looks like a unit test has slipped when we were landing #679 . This PR fixes that, along with other CI problems in pylibjuju.

QA Steps

CI tests should pass.

Notes & Discussion

This PR will act as a set of changes required to fix up the libjuju CI. There seems to be some configuration issues in juju-qa-jenkins too.

This shouldn't land until we see all green in the CI. We have some intermittent failures about internal event handling that will be addressed later.

Copy link
Contributor

@juanmanuel-tirado juanmanuel-tirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@juanmanuel-tirado
Copy link
Contributor

/build

2 similar comments
@juanmanuel-tirado
Copy link
Contributor

/build

@cderici
Copy link
Contributor Author

cderici commented Jun 7, 2022

/build

@tlm
Copy link
Member

tlm commented Jun 9, 2022

/build

6 similar comments
@tlm
Copy link
Member

tlm commented Jun 9, 2022

/build

@tlm
Copy link
Member

tlm commented Jun 9, 2022

/build

@tlm
Copy link
Member

tlm commented Jun 9, 2022

/build

@juanmanuel-tirado
Copy link
Contributor

/build

@cderici
Copy link
Contributor Author

cderici commented Jun 9, 2022

/build

@cderici
Copy link
Contributor Author

cderici commented Jun 9, 2022

/build

@cderici
Copy link
Contributor Author

cderici commented Jun 9, 2022

/build

2 similar comments
@cderici
Copy link
Contributor Author

cderici commented Jun 9, 2022

/build

@cderici
Copy link
Contributor Author

cderici commented Jun 9, 2022

/build

Otherwise juju will auto fix it before we could check the "error"
status and call the resolve()
@cderici
Copy link
Contributor Author

cderici commented Jun 9, 2022

/merge

@jujubot jujubot merged commit f2e50b8 into juju:master Jun 9, 2022
@cderici cderici deleted the unit-test-fix branch August 9, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants