-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JUJU-1172] Visiting the pylibjuju CI #681
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanmanuel-tirado
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG2M
/build |
2 similar comments
/build |
/build |
/build |
6 similar comments
/build |
/build |
/build |
/build |
/build |
/build |
/build |
2 similar comments
/build |
/build |
Otherwise juju will auto fix it before we could check the "error" status and call the resolve()
/merge |
jujubot
added a commit
that referenced
this pull request
Jun 10, 2022
#683 ## What's Changed * [JUJU-1155] Avoid incorrectly setting `series: kubernetes` for sidecar charms in k8s bundles by @cderici in #679 * [JUJU-1172] Visiting the pylibjuju CI by @cderici in #681 * [JUJU-1124] Avoid sending path across the wire for local resource file name by @cderici in #678 [JUJU-1155]: https://warthogs.atlassian.net/browse/JUJU-1155?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1172]: https://warthogs.atlassian.net/browse/JUJU-1172?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1124]: https://warthogs.atlassian.net/browse/JUJU-1124?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like a unit test has slipped when we were landing #679 . This PR fixes that, along with other CI problems in pylibjuju.
QA Steps
CI tests should pass.
Notes & Discussion
This PR will act as a set of changes required to fix up the libjuju CI. There seems to be some configuration issues in juju-qa-jenkins too.
This shouldn't land until we see all green in the CI.We have some intermittent failures about internal event handling that will be addressed later.So the time out we see in the integration tests are caused by the ephemeral node configurations on aws, the jobs spawn machines that are not powerful enough to run the tests within 120 mins (global timeout). [JUJU-1172] More cpu and memory on the ephemeral node for pylibjuju tests juju-qa-jenkins#24 will fix that.
The
check-merge
job will be fixed when the detect-merge-go-version builder is excluded from the python-libjuju jobs.