[JUJU-796] Add relate method and deprecate add-relation #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-w-shaw
force-pushed
the
JUJU-796_use_relate
branch
from
acbbfc7 to
09a5e58
Compare
juanmanuel-tirado
added
the
hint/do-not-merge
|
I label this as "do-not-merge" until a we have a consistent message in the juju CLI. |
jack-w-shaw
force-pushed
the
JUJU-796_use_relate
branch
from
09a5e58 to
3caaf1b
Compare
|
!!build!! |
cderici
suggested changes
Mar 30, 2022
jack-w-shaw
force-pushed
the
JUJU-796_use_relate
branch
from
3caaf1b to
7d89a38
Compare
cderici
approved these changes
Mar 31, 2022
This is to follow the pattern we are following going ahead with Juju. change the name of add-relation to relate, but keep add-relation, which calls relate for backwards compatibility This method is then to be removed at the next major version bump See this PR for more details juju/juju#13907
jack-w-shaw
force-pushed
the
JUJU-796_use_relate
branch
from
7d89a38 to
d810ec6
Compare
|
I just ran the CI manually for this one and all the tests pass, this is clear for landing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to follow the pattern we are following going ahead with Juju.
change the name of add-relation to relate, but keep add-relation, which
calls relate for backwards compatibility
This method should then be removed at the next major version bump
See this PR for more details
juju/juju#13907
QA Steps