Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JUJU-843] Attach-resource to check if given binary file #659

Merged
merged 1 commit into from
Mar 30, 2022
Merged

[JUJU-843] Attach-resource to check if given binary file #659

merged 1 commit into from
Mar 30, 2022

Conversation

cderici
Copy link
Contributor

@cderici cderici commented Mar 29, 2022

Description

The attach-resource method on pylibjuju assumes the resource read is plain text, so it borks when it gets a binary file as a resource.

Fixes #654

QA Steps

tox -e integration -- tests/integration/test_model.py::test_attach_resource

Notes & Discussion

@cderici
Copy link
Contributor Author

cderici commented Mar 30, 2022

!!build!!

@cderici cderici force-pushed the attach-resource-binary-file branch from 5bd1224 to efa00ec Compare March 30, 2022 17:54
@cderici
Copy link
Contributor Author

cderici commented Mar 30, 2022

$$merge$$

@jujubot jujubot merged commit b5c3185 into juju:master Mar 30, 2022
@cderici cderici deleted the attach-resource-binary-file branch March 30, 2022 20:20
@cderici cderici mentioned this pull request Apr 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonRichardson SimonRichardson SimonRichardson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem when trying to attach local binary resource
3 participants
@cderici @SimonRichardson @jujubot