Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUJU-234] Fix for small bug in task handling #589

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

cderici
Copy link
Contributor

@cderici cderici commented Nov 19, 2021

Description

This fixes a potential intermittent bug in task handling.

Fixes #588

QA Steps

N/A

Notes & Discussion

@cderici cderici changed the title Fix for small bug in task handling [JUJU-234] Fix for small bug in task handling Nov 19, 2021
Copy link
Contributor

@juanmanuel-tirado juanmanuel-tirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@cderici
Copy link
Contributor Author

cderici commented Nov 19, 2021

@juanmanuel-tirado Why don't we see the github-integration-tests-pylibjuju-edge test here?
https://github.com/CanonicalLtd/juju-qa-jenkins/pull/677 has landed.
@SimonRichardson do we need to restart the jenkins entirely to have this change to take effect?

@cderici
Copy link
Contributor Author

cderici commented Nov 19, 2021

$$merge$$

@jujubot jujubot merged commit a5ff411 into juju:master Nov 19, 2021
jujubot added a commit that referenced this pull request Dec 4, 2021
#599

2.9.5
^^^^^

Friday December 3 2021

* remove the event loop arguments by @cderici in #560
* add debug-log by @cderici in #562
* Model status by @juanmanuel-tirado in #563
* Pin cffi version to 1.14.6 for Python 3.5 by @cderici in #570
* Wait for applications to terminate on model reset by @balbirthomas in #572
* Babysitting python3.5 by @cderici in #571
* Deploy charmhub bundles by @cderici in #569
* Facade schemas for 2.9.17 by @SimonRichardson in #579
* Bundles with overlays by @cderici in #566
* Consistently getting a unit's public address by @cderici in #573
* [JUJU-158] Add python3.9 to setup.py by @cderici in #585
* [JUJU-157] Add note for removing services by @cderici in #583
* Added boolean entries to normalize values. by @juanmanuel-tirado in #582
* [JUJU-138] Streamlining asyncio tasks/events by @cderici in #580
* [JUJU-234] Fix for small bug in task handling by @cderici in #589
* Ensure all watchers validate for the Id by @SimonRichardson in #592
* [JUJU-276] Facade schemas for 2.9.19 by @cderici in #594
* [JUJU-238] Small bug fix for old ClientFacade support by @cderici in #593
* [JUJU-239] Debug-log parameters by @cderici in #595
* [JUJU-213] Local type `file` resource support by @cderici in #590
* [JUJU-289] Use provided series in deploy if supported by @jack-w-shaw in #596
* [JUJU-292] Update the charms in the tests to use Charmhub by @cderici in #597
* Legacy "services" for describing "applications" within bundles are no longer supported. "applications" can be used as a direct replacement for "services" in bundles.yaml.
* The websocket (ws) in a Connection object became a read-only property.


[JUJU-293] 

[JUJU-158]: https://warthogs.atlassian.net/browse/JUJU-158?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@cderici cderici deleted the fix-potential-bug-task-handling branch February 16, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential error in task handling code
3 participants