Remove explicit passing of event_loop into tests #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures in CI are non-related.
|
... already exists in integration/test_unit
cderici
force-pushed
the
clean-up-warnings
branch
from
316f968 to
2f7c236
Compare
jack-w-shaw
approved these changes
Jan 11, 2024
|
Should this be targeting 2.9, and be merged forward? |
I didn't think that it was happening in 2.9, but looks like it is. Well we can backport this no problem I think because there's no functionality change, just removing an argument wouldn't result it any conflicts. |
|
/merge |
Merged
jujubot
added a commit
that referenced
this pull request
Feb 13, 2024
#1024 ## What's Changed * Remove paramiko upper-bound by @gboutry in #1005 * Remove explicit passing of event_loop into tests by @cderici in #1006 * chore: remove the upper restrictions on the websockets dependency by @tonyandrewmeyer in #1007 * Target ceiling version by @cderici in #1008 * Make it easier to run tests using `make` by @cderici in #1012 * Avoid installing signal handlers to the event loop by @cderici in #1014 * feat: remove app block until done by @yanksyoon in #1017 * feat: remove app timeout by @yanksyoon in #1018 * Forward port latest changes from 2.9 onto 3.x by @cderici in #1022 #### Notes & Discussion JUJU-5414
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This clears up from the test output the flood of warnings from pytest that looks like (e.g. example):
QA Steps
No functionality changes. Though there were a couple of tests that I needed to manually get the running loop (where the test actually was using the
event_loop), so we need to make sure those are still passing.Notes & Discussions
Maybe need to be back-ported? I'm not sure yet.