Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-libjuju does not implement juju.get_controllers #529

Closed
zzehring opened this issue Aug 31, 2021 · 2 comments · Fixed by #546
Closed

python-libjuju does not implement juju.get_controllers #529

zzehring opened this issue Aug 31, 2021 · 2 comments · Fixed by #546

Comments

@zzehring
Copy link

python-libjuju/juju/juju.py

Lines 58 to 63 in 8a03711

def get_controllers(self):
"""Return list of all available controllers.
(maybe move this to Cloud?)
"""
raise NotImplementedError()

@cderici
Copy link
Contributor

cderici commented Sep 10, 2021

implement juju.py functions like juju.get_controllers

cderici added a commit to cderici/python-libjuju that referenced this issue Sep 20, 2021
@cderici
add juju.get_controllers
dd639b3 
Fixes juju#529
@cderici cderici mentioned this issue Sep 20, 2021
Merged
jujubot added a commit that referenced this issue Sep 21, 2021
@jujubot
Merge pull request #546 from cderici/juju-get-controller-issue-529
3d54f75 
#546

### Description

This PR adds some functions into the long dormant `Juju` class in `juju/juju.py`, cleans it up a little bit and add some tests for the added codes.

#### Includes 5 commits to:
- add `get_controllers` that returns a dictionary of info about the available controllers
- add `get_controller` that returns a ready-to-use `Controller` object that is connected to the controller with the given name
- remove a bunch of stub functions that were initially included for `budget` functionality (that is being deprecated)
- remove `get_agreements`
- fix function description

This also fixes #529 

### QA Steps

```bash
 $ tox -e integration -- tests/integration/test_juju.py
```

### Notes & Discussion

There might be more stub functions to be removed about functionalities that are being deprecated (I suspect `plans`). I simply don't know which ones are, so if you do, then please add a comment below and I'll update the PR.
@zzehring
Copy link
Author

zzehring commented Oct 4, 2021

Thanks!

This was referenced Apr 25, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bring juju/juju.py into life cderici/python-libjuju
2 participants
@cderici @zzehring