Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function connect in Model doesn't allow for max_frame_size #524

Closed
dasm opened this issue Aug 23, 2021 · 1 comment · Fixed by #527
Closed

Function connect in Model doesn't allow for max_frame_size #524

dasm opened this issue Aug 23, 2021 · 1 comment · Fixed by #527

Comments

@dasm
Copy link

dasm commented Aug 23, 2021

Based on the documentation (1), one of allowed parameters is max_frame_size. After providing it as keyword, I got an error

>>> from juju.model import Model
>>> from juju.loop import run
>>> model = Model()
>>> run(model.connect(model_name="openstack", max_frame_size=19491127))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/jujumanage/jujubackupall_packages/juju/loop.py", line 38, in run
    raise task.exception()
  File "/home/jujumanage/jujubackupall_packages/juju/model.py", line 547, in connect
    await self._connector.connect_model(model_name, **kwargs)
TypeError: connect_model() got an unexpected keyword argument 'max_frame_size'
>>> model = Model(max_frame_size=19491127)
>>> run(model.connect("openstack"))
>>> 
@dasm dasm changed the title Model connect doesn't allow for max_frame_size Function connect in Model doesn't allow for max_frame_size Aug 23, 2021
cderici added a commit to cderici/python-libjuju that referenced this issue Aug 24, 2021
@cderici
Copy link
Contributor

cderici commented Aug 24, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants