Skip to content

Commit

Permalink
Merge pull request #542 from cderici/skip-macaroon-tests-issue-534
Browse files Browse the repository at this point in the history
#542

### Description

Marks the `test_macaroon_auth` tests (there are 3 of them) with `skip`.

Fixes #534 

### Notes & Discussion

These tests are several years old, and they were always failing, in fact, they were also marked with `xfail` by their author, currently they seem to have started to block the entire test run on the CI, so they need to be revised. 
Until then, skipping them seems to be reasonable.
  • Loading branch information
jujubot authored Sep 15, 2021
2 parents f586f37 + b147722 commit 5bdf979
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions tests/integration/test_macaroon_auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@

@base.bootstrapped
@pytest.mark.asyncio
@pytest.mark.xfail
# @pytest.mark.xfail
@pytest.mark.skip('one of old macaroon_auth tests, needs to be revised')
async def test_macaroon_auth(event_loop):
auth_info, username = agent_auth_info()
# Create a bakery client that can do agent authentication.
Expand All @@ -37,7 +38,8 @@ async def test_macaroon_auth(event_loop):

@base.bootstrapped
@pytest.mark.asyncio
@pytest.mark.xfail
# @pytest.mark.xfail
@pytest.mark.skip('one of old macaroon_auth tests, needs to be revised')
async def test_macaroon_auth_with_bad_key(event_loop):
auth_info, username = agent_auth_info()
# Use a random key rather than the correct key.
Expand Down Expand Up @@ -65,7 +67,8 @@ async def test_macaroon_auth_with_bad_key(event_loop):

@base.bootstrapped
@pytest.mark.asyncio
@pytest.mark.xfail
# @pytest.mark.xfail
@pytest.mark.skip('one of old macaroon_auth tests, needs to be revised')
async def test_macaroon_auth_with_unauthorized_user(event_loop):
auth_info, username = agent_auth_info()
# Create a bakery client can do agent authentication.
Expand Down

0 comments on commit 5bdf979

Please sign in to comment.