Remove the use of --collapse-inline-tag-whitespace pass, which result…

…s in too eager whitespace minification on minified HTML pages. Fixes emscripten-core#22188. See also terser/html-minifier-terser#179.
juj · Aug 9, 2024 · 0a3e825 · 0a3e825
1 parent 08f5c0f
commit 0a3e825
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/tools/link.py b/tools/link.py
@@ -2589,7 +2589,6 @@ def minify_html(filename):
   # -g1 and greater retain whitespace and comments in source
   if settings.DEBUG_LEVEL == 0:
     opts += ['--collapse-whitespace',
-             '--collapse-inline-tag-whitespace',
              '--remove-comments',
              '--remove-tag-whitespace',
              '--sort-attributes',
@@ -2607,6 +2606,10 @@ def minify_html(filename):
              '--minify-js', 'true']
 
   # html-minifier also has the following options, but they look unsafe for use:
+  # '--collapse-inline-tag-whitespace': removes whitespace between inline tags in visible text,
+  #                                     causing words to be joined together. See
+  #                                     https://github.com/terser/html-minifier-terser/issues/179
+  #                                     https://github.com/emscripten-core/emscripten/issues/22188
   # '--remove-optional-tags': removes e.g. <head></head> and <body></body> tags from the page.
   #                           (Breaks at least browser.test_sdl2glshader)
   # '--remove-empty-attributes': removes all attributes with whitespace-only values.