Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errno label to fuse ops metric #4656

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

polyrabbit
Copy link
Contributor

@polyrabbit polyrabbit commented Apr 7, 2024

Senario:

  1. Better understanding users' pattern
  2. Set up alarm rules on abnormal error rate
image

@polyrabbit polyrabbit force-pushed the fuse-label-errno branch 2 times, most recently from eed3bdb to 06947bd Compare April 8, 2024 01:29
pkg/vfs/accesslog.go Outdated Show resolved Hide resolved
@polyrabbit polyrabbit force-pushed the fuse-label-errno branch 2 times, most recently from f41bb1c to 408ea22 Compare April 8, 2024 10:03
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 53.57%. Comparing base (b281022) to head (4167043).
Report is 7 commits behind head on main.

❗ Current head 4167043 differs from pull request most recent head bcdfbb1. Consider uploading reports for the commit bcdfbb1 to get more accurate results

Files Patch % Lines
pkg/vfs/internal.go 0.00% 0 Missing and 1 partial ⚠️
pkg/vfs/vfs.go 96.55% 1 Missing ⚠️
pkg/vfs/vfs_unix.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4656       +/-   ##
===========================================
+ Coverage   24.97%   53.57%   +28.59%     
===========================================
  Files          25      124       +99     
  Lines       15994    33547    +17553     
===========================================
+ Hits         3995    17973    +13978     
- Misses      11512    13405     +1893     
- Partials      487     2169     +1682     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Changxin Miao <[email protected]>
@davies davies merged commit 2481a13 into juicedata:main Apr 12, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants