Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/acl: clear sgid in some cases #4551

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

jiefenghuang
Copy link
Contributor

close #4496

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 55.73%. Comparing base (249ea17) to head (196c001).

Files Patch % Lines
pkg/meta/base.go 0.00% 6 Missing ⚠️
pkg/meta/redis.go 42.85% 3 Missing and 1 partial ⚠️
pkg/meta/sql.go 42.85% 3 Missing and 1 partial ⚠️
pkg/meta/tkv.go 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4551      +/-   ##
==========================================
+ Coverage   55.67%   55.73%   +0.05%     
==========================================
  Files         157      157              
  Lines       42941    42968      +27     
==========================================
+ Hits        23909    23947      +38     
+ Misses      16378    16362      -16     
- Partials     2654     2659       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiefenghuang jiefenghuang marked this pull request as ready for review March 21, 2024 07:31
@jiefenghuang
Copy link
Contributor Author

Currently check user != root instead of capabilities
image

@davies davies merged commit a190f55 into juicedata:main Mar 21, 2024
32 checks passed
@jiefenghuang jiefenghuang deleted the fix/acl-sgid branch April 15, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flags not removed after setfacl
2 participants