mount: restart mount process gracefully #4392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4392 +/- ##
==========================================
- Coverage 56.00% 55.31% -0.70%
==========================================
Files 156 157 +1
Lines 40417 41094 +677
==========================================
+ Hits 22636 22731 +95
- Misses 15262 15836 +574
- Partials 2519 2527 +8 ☔ View full report in Codecov by Sentry. |
zhijian-pro
force-pushed
the
graceful_restart
branch
from
1f3aeaa
to
22e4602
Compare
# Conflicts: # cmd/mount_test.go
|
Badger does not support smooth upgrades because only one database connection can be active at a time. |
zhijian-pro
force-pushed
the
graceful_restart
branch
from
5b7fe1e
to
4f86aae
Compare
davies
commented
Mar 6, 2024
pkg/meta/base.go
Outdated
| m.sid = uint64(v) | ||
| if err = m.en.doNewSession(m.newSessionInfo()); err != nil { | ||
| return fmt.Errorf("create session: %s", err) | ||
| if err := m.en.doNewSession(m.newSessionInfo()); err != nil { |
There was a problem hiding this comment.
should use existing session
davies
commented
Mar 6, 2024
davies
commented
Mar 6, 2024
davies
commented
Mar 6, 2024
davies
commented
Mar 6, 2024
davies
commented
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.