Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compact: add new compact cmd, used for specific path #4337

Merged
merged 4 commits into from
Jan 15, 2024
Merged

cmd/compact: add new compact cmd, used for specific path #4337

merged 4 commits into from
Jan 15, 2024

Conversation

jiefenghuang
Copy link
Contributor

Support triggering compaction of all files under a given directory #4303

@codecov Codecov
Copy link

codecov bot commented Jan 12, 2024 •
edited
Loading

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (7b85645) 55.84% compared to head (817ead3) 64.50%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/meta/base.go 0.00% 33 Missing ⚠️
pkg/meta/interface.go 33.33% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4337      +/-   ##
==========================================
+ Coverage   55.84%   64.50%   +8.65%     
==========================================
  Files         153       24     -129     
  Lines       39755    15119   -24636     
==========================================
- Hits        22202     9752   -12450     
+ Misses      15059     4034   -11025     
+ Partials     2494     1333    -1161

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiefenghuang jiefenghuang self-assigned this Jan 12, 2024
@jiefenghuang jiefenghuang added the kind/feature New feature or request label Jan 12, 2024
davies
davies reviewed Jan 12, 2024
View reviewed changes
cmd/compact_unix.go Outdated Show resolved Hide resolved
davies
davies reviewed Jan 12, 2024
View reviewed changes
pkg/meta/base.go Outdated Show resolved Hide resolved
SandyXSD
SandyXSD reviewed Jan 12, 2024
View reviewed changes
.gitignore Show resolved Hide resolved
cmd/compact_windows.go Show resolved Hide resolved
cmd/compact_unix.go Outdated Show resolved Hide resolved
cmd/compact_unix.go Outdated Show resolved Hide resolved
cmd/compact_unix.go Outdated Show resolved Hide resolved
cmd/compact_unix.go Show resolved Hide resolved
cmd/compact_unix.go Show resolved Hide resolved
pkg/meta/base.go Outdated Show resolved Hide resolved
pkg/meta/interface.go Show resolved Hide resolved
SandyXSD
SandyXSD reviewed Jan 15, 2024
View reviewed changes
pkg/vfs/internal.go Outdated Show resolved Hide resolved
SandyXSD
SandyXSD reviewed Jan 15, 2024
View reviewed changes
cmd/compact_unix.go Outdated Show resolved Hide resolved
@jiefenghuang jiefenghuang merged commit b1b6d29 into juicedata:main Jan 15, 2024
27 checks passed
@jiefenghuang jiefenghuang deleted the feature/cmd-compact branch January 15, 2024 09:13
@jiefenghuang jiefenghuang linked an issue Jan 15, 2024 that may be closed by this pull request
Support triggering compaction of all files under a given directory #4303
Closed
@lidaohang
Copy link
Contributor

mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandyXSD SandyXSD SandyXSD approved these changes

@davies davies Awaiting requested review from davies

Assignees

@jiefenghuang jiefenghuang

Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support triggering compaction of all files under a given directory
4 participants
@jiefenghuang @lidaohang @davies @SandyXSD