cmd/compact: add new compact cmd, used for specific path #4333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4333 +/- ##
==========================================
+ Coverage 55.82% 56.03% +0.21%
==========================================
Files 153 155 +2
Lines 39733 40024 +291
==========================================
+ Hits 22181 22428 +247
- Misses 15059 15091 +32
- Partials 2493 2505 +12 ☔ View full report in Codecov by Sentry. |
davies
reviewed
Jan 10, 2024
| @@ -0,0 +1,111 @@ | |||
| /* | |||
| * JuiceFS, Copyright 2020 Juicedata, Inc. | |||
davies
reviewed
Jan 10, 2024
| ) | ||
|
|
||
| func GetInode(path string) (uint64, error) { | ||
| dpath, err := filepath.Abs(path) |
davies
reviewed
Jan 10, 2024
| @@ -249,9 +249,9 @@ func (m *dbMeta) Setlk(ctx Context, inode Ino, owner_ uint64, block bool, ltype | |||
| return err | |||
| } | |||
|
|
|||
| func (r *dbMeta) ListLocks(ctx context.Context, inode Ino) ([]PLockItem, []FLockItem, error) { | |||
| func (m *dbMeta) ListLocks(ctx context.Context, inode Ino) ([]PLockItem, []FLockItem, error) { | |||
There was a problem hiding this comment.
We can move these into another PR.
davies
reviewed
Jan 10, 2024
| $ juicefs compact --path /mnt/jfs/foo redis://localhost | ||
|
|
||
| # max depth of 5 | ||
| $ juicefs summary --path /mnt/jfs/foo --depth 5 /mnt/jfs/foo redis://localhost |
davies
reviewed
Jan 10, 2024
| Description: ` | ||
| Examples: | ||
| # compact with path | ||
| $ juicefs compact --path /mnt/jfs/foo redis://localhost |
There was a problem hiding this comment.
We usually need either META-URL or mount point, not both.
compact could be a tool used by end-user (not admin), so a mountpoint will be easier. The end-user may don't have the secret in META-URL.
SandyXSD
reviewed
Jan 10, 2024
| // new meta client | ||
| metaConf := meta.DefaultConf() | ||
| metaConf.MaxDeletes = int(deleteConcurrency) | ||
| client := meta.NewClient(metaUri, metaConf) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4303