Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quota: atomically set limitation #4158

Merged
merged 19 commits into from
Nov 13, 2023
Merged

quota: atomically set limitation #4158

merged 19 commits into from
Nov 13, 2023

Conversation

Hexilee
Copy link
Contributor

@Hexilee Hexilee commented Nov 10, 2023

No description provided.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (5163180) 46.34% compared to head (c8e85c9) 55.42%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4158      +/-   ##
==========================================
+ Coverage   46.34%   55.42%   +9.08%     
==========================================
  Files         152      120      -32     
  Lines       38664    30717    -7947     
==========================================
- Hits        17917    17025     -892     
+ Misses      18563    11682    -6881     
+ Partials     2184     2010     -174     
Files Coverage Δ
pkg/meta/dump.go 76.27% <0.00%> (ø)
pkg/meta/sql.go 59.44% <91.17%> (+0.15%) ⬆️
pkg/meta/redis.go 64.34% <87.09%> (-2.02%) ⬇️
pkg/meta/tkv.go 70.41% <85.18%> (+0.08%) ⬆️
pkg/meta/base.go 57.72% <53.57%> (-2.56%) ⬇️

... and 96 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hexilee Hexilee marked this pull request as ready for review November 10, 2023 06:26
@Hexilee Hexilee requested a review from davies November 10, 2023 06:29
Copy link

Signed-off-by: xixi <[email protected]>
Signed-off-by: xixi <[email protected]>
Signed-off-by: xixi <[email protected]>
// limit is deleted, skip
created = false
return nil
return errors.Errorf("limitation not set or deleted")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this into the case for e is redis.Nil

Signed-off-by: xixi <[email protected]>
@davies davies merged commit c224e22 into main Nov 13, 2023
28 of 29 checks passed
@davies davies deleted the quota/aotmic-set branch November 13, 2023 06:07
SandyXSD pushed a commit that referenced this pull request Nov 24, 2023
davies pushed a commit that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants