fix: get pod by pv volumeHandle #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zwwhdls
commented
Nov 17, 2023
zwwhdls
commented
- get all pvc when multiple pvs has the same volumeHandle when list app pods
- requeue mount pod periodically to avoid leaking in both kubelet polling and apiserver watching
Signed-off-by: zwwhdls <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #801 +/- ##
==========================================
- Coverage 36.56% 36.47% -0.10%
==========================================
Files 36 36
Lines 4365 4376 +11
==========================================
Hits 1596 1596
- Misses 2620 2631 +11
Partials 149 149 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zwwhdls <[email protected]>
Hexilee
reviewed
Nov 20, 2023
| @@ -84,16 +84,18 @@ func (m *PodController) Reconcile(ctx context.Context, request reconcile.Request | |||
| continue | |||
| } | |||
| if uniqueId != "" && (p.Spec.CSI.VolumeHandle == uniqueId || p.Spec.StorageClassName == uniqueId) { | |||
| pv = &p | |||
| break | |||
| relatedPVs = append(relatedPVs, &p) | |||
There was a problem hiding this comment.
We should throw a warning when the same VolumeHandle is used by multiple PVs.
Signed-off-by: zwwhdls <[email protected]>
Hexilee
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.