Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount pod: use node selector instead of node name #755

Merged
merged 8 commits into from
Oct 9, 2023

Conversation

Hexilee
Copy link
Contributor

@Hexilee Hexilee commented Sep 20, 2023

close #754

@zwwhdls
Copy link
Member

zwwhdls commented Sep 27, 2023

Please fix when pod error because of lack of resources.

@codecov-commenter
Copy link

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (290a68c) 38.18% compared to head (31117d2) 38.02%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
- Coverage   38.18%   38.02%   -0.16%     
==========================================
  Files          33       33              
  Lines        4112     4131      +19     
==========================================
+ Hits         1570     1571       +1     
- Misses       2391     2408      +17     
- Partials      151      152       +1     
Files Coverage Δ
pkg/controller/pod_controller.go 0.00% <0.00%> (ø)
pkg/juicefs/mount/pod_mount.go 34.44% <75.00%> (-0.10%) ⬇️
pkg/k8sclient/client.go 14.40% <0.00%> (-0.78%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwwhdls zwwhdls merged commit eb067a3 into master Oct 9, 2023
23 checks passed
@zwwhdls zwwhdls deleted the mountpod/node-selector branch October 9, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mount pod: use node selector instead of node name
3 participants