Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance csi-doctor.sh collect #729

Merged
merged 6 commits into from
Sep 1, 2023
Merged

enhance csi-doctor.sh collect #729

merged 6 commits into from
Sep 1, 2023

Conversation

timfeirg
Copy link
Collaborator

@timfeirg timfeirg commented Aug 29, 2023

  • multi-pv support for the collect command
  • add kubectl top information as well
  • collect juicefs doctor results as well
  • ignore non-jfs volumes
image

@timfeirg timfeirg marked this pull request as draft August 29, 2023 06:31
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.16% ⚠️

Comparison is base (de402d3) 38.35% compared to head (d3ba3a5) 38.19%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
- Coverage   38.35%   38.19%   -0.16%     
==========================================
  Files          33       33              
  Lines        4065     4084      +19     
==========================================
+ Hits         1559     1560       +1     
- Misses       2359     2377      +18     
  Partials      147      147              

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timfeirg timfeirg requested a review from zwwhdls August 30, 2023 07:22
@timfeirg timfeirg marked this pull request as ready for review August 30, 2023 07:23
@timfeirg timfeirg changed the title fix csi-doctor.sh collect enhance csi-doctor.sh collect Aug 30, 2023
@timfeirg
Copy link
Collaborator Author

I've added JuiceFS PV detection in the latest commit, non-jfs pvs will be ignored @zwwhdls

scripts/csi-doctor.sh Outdated Show resolved Hide resolved
scripts/csi-doctor.sh Outdated Show resolved Hide resolved
@zwwhdls zwwhdls merged commit 4dedd3f into master Sep 1, 2023
22 checks passed
@zwwhdls zwwhdls deleted the feature/troubleshooting branch September 1, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants