-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance csi-doctor.sh collect #729
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
timfeirg
commented
Aug 29, 2023
•
edited
Loading
edited
- multi-pv support for the collect command
- add kubectl top information as well
- collect juicefs doctor results as well
- ignore non-jfs volumes
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #729 +/- ##
==========================================
- Coverage 38.35% 38.19% -0.16%
==========================================
Files 33 33
Lines 4065 4084 +19
==========================================
+ Hits 1559 1560 +1
- Misses 2359 2377 +18
Partials 147 147 ☔ View full report in Codecov by Sentry. |
zwwhdls
reviewed
Aug 30, 2023
I've added JuiceFS PV detection in the latest commit, non-jfs pvs will be ignored @zwwhdls |
zwwhdls
requested changes
Sep 1, 2023
zwwhdls
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.