Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Secret Finalizer doesn't release if retain reclaimPolicy #734

Closed
kyungwan-nam opened this issue Aug 30, 2023 · 0 comments · Fixed by #735
Closed

[BUG] Secret Finalizer doesn't release if retain reclaimPolicy #734

kyungwan-nam opened this issue Aug 30, 2023 · 0 comments · Fixed by #735
Labels
kind/bug Something isn't working

Comments

@kyungwan-nam
Copy link
Contributor

What happened:

secretFinalizer (#707) does not release if retain ReclaimPolicy.

What you expected to happen:

the finalizer on the secret must be release when removing related pvc.

How to reproduce it (as minimally and precisely as possible):

storageclass with reclaimPolicy: Retain, secretFinalizer: "true"

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: juicefs
provisioner: csi.juicefs.com
parameters:
...
  # requires the juicefs-provisioner
  secretFinalizer: "true"
  # requires the juicefs-provisioner
  pathPattern: "${.PVC.namespace}-${.PVC.name}"
allowVolumeExpansion: true
reclaimPolicy: Retain

Anything else we need to know?

Environment:

  • JuiceFS CSI Driver version (which image tag did your CSI Driver use):
  • Kubernetes version (e.g. kubectl version):
  • Object storage (cloud provider and region):
  • Metadata engine info (version, cloud provider managed or self maintained):
  • Network connectivity (JuiceFS to metadata engine, JuiceFS to object storage):
  • Others:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant