Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support secret finalizer #707

Closed
kyungwan-nam opened this issue Aug 1, 2023 · 1 comment
Closed

[FEATURE] Support secret finalizer #707

kyungwan-nam opened this issue Aug 1, 2023 · 1 comment
Labels
kind/feature New feature or request

Comments

@kyungwan-nam
Copy link
Contributor

What feature you'd like to add:

juicefs pv depends on a secret.
when deleting a pv, juicefs-csi-driver can't cleanup the data for the pv if the secret has been removed.

I think this problem can be solved with finalizers

  1. when provisioning a pvc, set the finalizer for the secret.
  2. when deleting a pvc, unset the finalizer for the secret if there are no pv referring to the secret.

Why is this feature needed:

@kyungwan-nam kyungwan-nam added the kind/feature New feature or request label Aug 1, 2023
@zwwhdls
Copy link
Member

zwwhdls commented Aug 21, 2023

complete by #708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants