Use a re-exported serde_json dependency in macros #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just one thing, a CHANGELOG.md entry for the change would be good to add in |
Sufflope
force-pushed
the
1172_undocumented_serde_json_dependency
branch
from
0b61c63 to
2c498b9
Compare
|
Done. I rebased on latest master and merged the duplicate |
juhaku
pushed a commit
that referenced
this pull request
Dec 18, 2024
Re-exports `serde_json` to enable users to not directly depend on `serde_json`. Fixes #1172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, here is a proposal to avoid shadow-depending on
serde_jsonwhen using derives.Fixes #1172