Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utoipa-gen] MediaTypeAttr, Encoding: Parse encodings #1237

Merged
merged 0 commits into from
Dec 18, 2024

Conversation

jsoo1
Copy link
Contributor

@jsoo1 jsoo1 commented Dec 13, 2024

Though only in a limited fashion - notable fields are still not
implemented.

Though this does let you do:

   request_body(
       content(...)
       encoding(
           ("field_name", (
               content_type = "application/json",
               explode = true,
               allow_reserved = true,
           ))
       )
   )

Partially addresses #1087

Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it is missing CHANGELOG.md entry for the addition. Perhaps under Unreleased and Added section by placing newest to top.

utoipa-gen/src/path/media_type/encoding.rs Outdated Show resolved Hide resolved
utoipa-gen/src/path/media_type/encoding.rs Outdated Show resolved Hide resolved
utoipa-gen/src/path/media_type/encoding.rs Outdated Show resolved Hide resolved
utoipa-gen/src/path/media_type.rs Outdated Show resolved Hide resolved
Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks for putting the effort 🙂

@juhaku juhaku merged commit 24dd6d4 into juhaku:master Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants