Skip to content

Commit

Permalink
Merge pull request #5 from davismcphee/discover-redesign-resize-button
Browse files Browse the repository at this point in the history
[Discover] Remove some whitespace around the Unified Histogram resize button
  • Loading branch information
jughosta authored Sep 8, 2023
2 parents b34d3bc + 5357b53 commit 1ec4869
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 14 deletions.
2 changes: 1 addition & 1 deletion src/plugins/unified_histogram/public/layout/layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ export const UnifiedHistogramLayout = ({
chart={chart}
breakdown={breakdown}
appendHitsCounter={appendHitsCounter}
appendHistogram={showFixedPanels ? <EuiSpacer size="s" /> : <EuiSpacer size="l" />}
appendHistogram={<EuiSpacer size="s" />}
disableAutoFetching={disableAutoFetching}
disableTriggers={disableTriggers}
disabledActions={disabledActions}
Expand Down
15 changes: 2 additions & 13 deletions src/plugins/unified_histogram/public/panels/panels_resizable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,7 @@
* Side Public License, v 1.
*/

import {
EuiResizableContainer,
useEuiTheme,
useGeneratedHtmlId,
useResizeObserver,
} from '@elastic/eui';
import { EuiResizableContainer, useGeneratedHtmlId, useResizeObserver } from '@elastic/eui';
import type { ResizeTrigger } from '@elastic/eui/src/components/resizable_container/types';
import { css } from '@emotion/react';
import { isEqual, round } from 'lodash';
Expand Down Expand Up @@ -162,12 +157,6 @@ export const PanelsResizable = ({
disableResizeWithPortalsHack();
}, [disableResizeWithPortalsHack, resizeWithPortalsHackIsResizing]);

const { euiTheme } = useEuiTheme();
const buttonCss = css`
margin-top: -${euiTheme.size.base};
margin-bottom: 0;
`;

return (
<EuiResizableContainer
className={className}
Expand All @@ -189,7 +178,7 @@ export const PanelsResizable = ({
{topPanel}
</EuiResizablePanel>
<EuiResizableButton
css={[resizeWithPortalsHackButtonCss, buttonCss]}
css={resizeWithPortalsHackButtonCss}
data-test-subj="unifiedHistogramResizableButton"
/>
<EuiResizablePanel
Expand Down

0 comments on commit 1ec4869

Please sign in to comment.