Skip to content

Commit

Permalink
API parameters with escaped characters fail in IE7-9. Fix #19
Browse files Browse the repository at this point in the history
  • Loading branch information
mynetx committed Jun 23, 2013
1 parent 1816033 commit 5750366
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
codebird-js - changelog
=======================

2.4.1-rc1 (2013-06-23)
2.4.1 (not yet released)
+ Pass JSHint validation
+ #15 Allow to assign custom proxy address
- #19 API parameters with escaped characters fail in IE7-9

2.4.0 (2013-06-15)
+ Support multipart file uploads
Expand Down
8 changes: 4 additions & 4 deletions codebird.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* A Twitter library in JavaScript
*
* @package codebird
* @version 2.4.1-rc1
* @version 2.4.1
* @author J.M. <[email protected]>
* @copyright 2010-2013 J.M. <[email protected]>
*
Expand Down Expand Up @@ -126,7 +126,7 @@ var Codebird = function () {
/**
* The current Codebird version
*/
var _version = "2.4.1-rc1";
var _version = "2.4.1";

/**
* Sets the OAuth consumer key and secret (App key)
Expand Down Expand Up @@ -774,14 +774,14 @@ var Codebird = function () {
var oauth_params = _clone(sign_base_params);
for (key in params) {
value = params[key];
sign_base_params[key] = _url(value);
sign_base_params[key] = value;
}
var keys = _ksort(sign_base_params);
var sign_base_string = "";
for (var i = 0; i < keys.length; i++) {
key = keys[i];
value = sign_base_params[key];
sign_base_string += key + "=" + value + "&";
sign_base_string += key + "=" + _url(value) + "&";
}
sign_base_string = sign_base_string.substring(0, sign_base_string.length - 1);
var signature = _sha1(httpmethod + "&" + _url(method) + "&" + _url(sign_base_string));
Expand Down

0 comments on commit 5750366

Please sign in to comment.