Add Random IP Assignment #983
Conversation
|
Hi, sorry for the delay, we are not against this feature, we just need some more time to think about how we want to implement it. We will revisit this after we have released 0.17.0. |
|
@blobcode there is no need to close it. What Kristoffer meant is that we are in a feature freeze for 0.17 - which will be released very soon. As soon as we release it, we can merge again. |
|
Apologies - I misunderstood and didn’t want to leave you with a dead pr. |
|
Alternatively, would it be possible to specify a specific IP for a client? We are considering deployment of Tailscale on a product we maintain and it would be helpful to be able to assign addresses based on the serial number or ID of the device. |
|
Anything I can do to help move this PR along? |
| ips = append(ips, *ip) | ||
| } | ||
|
|
||
| return shuffleIPs(ips), err |
There was a problem hiding this comment.
The error is being handled in the loop, it will always be nil and it should be explicit as such.
return shuffleIPs(ips), nil
|
Closing this for now, it will require a large rebase after our code reorg work goes in. If picked up again, please open when ready. It will need to be rethought for now. |
Adds / Fixes #968
This PR adds a config option for optional random ip assignment within the predefined ip prefix(es).
I'm a bit rusty in go so I'm open to feedback if there are any issues / suggestions.