Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli registration of expired machines #754

Merged
merged 5 commits into from
Aug 20, 2022

Conversation

Aluxima
Copy link
Contributor

@Aluxima Aluxima commented Aug 19, 2022

Fixes the CLI registration of machines already present in DB:

  • Machines that logged out were not added to registration cache when joining again
  • If the machine was still in cache (<15min after the first registration), expiry was not updated
  • Registration cache was not cleaned up after successful machine registration

Checks that the machine is registered with the right namespace

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #522

@Aluxima Aluxima marked this pull request as ready for review August 19, 2022 11:20
Signed-off-by: Laurent Marchaud <[email protected]>
@Aluxima Aluxima force-pushed the expired-machine-registration branch from c63030d to 0c66590 Compare August 19, 2022 12:12
Signed-off-by: Laurent Marchaud <[email protected]>
@Aluxima Aluxima marked this pull request as draft August 19, 2022 13:17
@Aluxima Aluxima marked this pull request as ready for review August 19, 2022 13:48
@Aluxima
Copy link
Contributor Author

Aluxima commented Aug 19, 2022

Fixes #749 as well

@juanfont
Copy link
Owner

This is an excellent catch! Thank you very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The client cannot regenerate the registration key
2 participants