Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove gin completely, ~2MB reduction on final binary #677

Merged
merged 3 commits into from
Jul 20, 2022
Merged

remove gin completely, ~2MB reduction on final binary #677

merged 3 commits into from
Jul 20, 2022

Conversation

huskyii
Copy link
Contributor

@huskyii huskyii commented Jul 15, 2022 •
edited
Loading

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

@huskyii
Copy link
Contributor Author

huskyii commented Jul 15, 2022

@kradalby hi, as this PR changes go.sum/go.mod, vendorSha256 in flake.nix line 27 needs to be updated, how to compute the sha256?

@restanrm
Copy link
Contributor

@kradalby hi, as this PR changes go.sum/go.mod, vendorSha256 in flake.nix line 27 needs to be updated, how to compute the sha256?

I think you just have to run it locally and it will print the sha256 in your terminal or in the github actions fail log.

@kradalby
Copy link
Collaborator

You can either run nix build locally or check the failed the build:

https://github.com/juanfont/headscale/runs/7362820827?check_suite_focus=true#step:5:183

@huskyii
Copy link
Contributor Author

huskyii commented Jul 19, 2022

@restanrm @kradalby

Main workstation runs OpenBSD, do not have access to nix.
Check GitHub Action's build log works, thx~

@kradalby kradalby merged commit ea7b3ba into juanfont:main Jul 20, 2022
@huskyii huskyii deleted the remove_gin branch July 20, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kradalby kradalby kradalby approved these changes

@juanfont juanfont Awaiting requested review from juanfont juanfont is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huskyii @restanrm @kradalby