-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for 0.23 #2096
Conversation
WalkthroughThe documentation for Headscale has been updated to reflect changes in parameter names and terminology for clarity. Specifically, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Headscale
participant Config
User->>Config: Update configuration
Config->>Headscale: Load ACL from policy.path
Headscale->>User: Apply ACL settings
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
Early access features: disabledWe are currently testing the following features in early access:
Note:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- docs/acls.md (1 hunks)
- docs/exit-node.md (2 hunks)
Files skipped from review due to trivial changes (1)
- docs/exit-node.md
Files skipped from review as they are similar to previous changes (1)
- docs/acls.md
As per 1193a50, the oldest support Tailscale client version is 1.42. The documentation and the OS specific endpoints Can I just get rid of this and assume 1.42+? This would remove some probably useless and no longer required instructions in the documentation and also from the OS specific endpoints |
* Add newlines between commands to improve readability * Use nodes instead on name * Remove query parameter from link to Tailscale docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (4)
- docs/acls.md (1 hunks)
- docs/exit-node.md (2 hunks)
- docs/remote-cli.md (1 hunks)
- docs/reverse-proxy.md (2 hunks)
Files skipped from review due to trivial changes (1)
- docs/acls.md
Files skipped from review as they are similar to previous changes (1)
- docs/exit-node.md
Additional context used
LanguageTool
docs/remote-cli.md
[grammar] ~71-~71: Did you mean “you are”, “yours are” or “your”?
Context: ...The API key is needed to make sure that your are allowed to access the server. The key i...(YOUR_RE)
docs/reverse-proxy.md
[grammar] ~83-~83: The verb “add” needs to be in the to-infinitive form.
Context: ...ails upgrade_failed ``` ### Envoy You need add a new upgrade_type named `tailscale-con...(MISSING_TO_BEFORE_A_VERB)
Additional comments not posted (5)
docs/remote-cli.md (4)
50-52
: Improved code block formatting.The adjustment to the indentation of the shell command example enhances the readability of the instructions.
56-59
: Improved code block formatting.The adjustment to the indentation of the shell command example enhances the readability of the instructions.
63-66
: Improved code block formatting.The adjustment to the indentation of the shell command example enhances the readability of the instructions.
78-80
: Improved code block formatting.The adjustment to the indentation of the shell command example enhances the readability of the instructions.
docs/reverse-proxy.md (1)
14-14
: Approved: The added phrase clarifies the purpose of WebSockets support.The change enhances the explanation by specifying that WebSockets support is required to communicate with Tailscale clients.
* Indent blocks below line numbers to restore numbering * Fix minor typos
* Websocket support is always required now * s/see detail/see details
* Replace the warning section with a warning admonition * Fix TODO link back to the regular linux documentation
* Remove a stray sentence * Remove "headscale" before serve * Indent line continuation * Replace hardcoded 0.22 with <VERSION> * Fix path in debug image to /ko-app/headscale Fixes: juanfont#1822 aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (6)
- docs/remote-cli.md (1 hunks)
- docs/reverse-proxy.md (2 hunks)
- docs/running-headscale-container.md (8 hunks)
- docs/running-headscale-linux-manual.md (2 hunks)
- docs/running-headscale-openbsd.md (3 hunks)
- docs/running-headscale-sealos.md (2 hunks)
Files skipped from review due to trivial changes (4)
- docs/remote-cli.md
- docs/reverse-proxy.md
- docs/running-headscale-openbsd.md
- docs/running-headscale-sealos.md
Additional context used
Markdownlint
docs/running-headscale-container.md
160-160: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
160-160: Expected: indented; Actual: fenced
Code block style(MD046, code-block-style)
Additional comments not posted (6)
docs/running-headscale-linux-manual.md (2)
3-6
: Improved warning note formatting and phrasing.The changes to the warning note are approved for the following reasons:
- The reformatting to a more prominent warning block enhances visibility for users.
- The reformatting of the phrase "Outdated and advanced" to a warning format emphasises the caution regarding the documentation's relevance.
- The rephrasing to include a direct link to the distro-specific documentation improves navigability for users seeking current information.
5-6
: Verify the impact of removing the SQLite database creation section.The section detailing the creation of an empty SQLite database has been removed. Please verify the following:
- Is this step no longer necessary for setting up and running
headscale
on Linux?- Has this information been relocated to another part of the documentation?
- Will removing this section have any unintended consequences for users following this guide?
To verify the impact of this change, please provide additional context or confirm that the removal of this section is intentional and will not negatively affect users.
docs/running-headscale-container.md (4)
55-55
: LGTM!The change simplifies the command and enhances readability without affecting the functionality.
70-70
: LGTM!The changes standardise the placeholder format and allow for easier updates in the future without affecting the functionality.
Also applies to: 77-78
105-105
: LGTM!The change simplifies the command and enhances readability without affecting the functionality.
120-120
: LGTM!The changes reflect updates to the container's internal structure and enhance consistency without affecting the functionality.
Also applies to: 148-148, 158-158, 161-161
Yes please! Quick look at Same for Preferably do it as a followup PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!, these changes are incredibly helpful!
Two small changes, I might have confused myself gotten it the wrong way around with docker, but right now the serve and user example is not calling docker the same way.
Thx for the feedback; will submit a new PR for this later. |
* Simplify /windows to the bare minimum. Also remove the /windows/tailscale.reg endpoint as its generated file is no longer valid for current Tailscale versions. * Update and simplify the windows documentation accordingly. * Add a "Unattended mode" section to the troubleshooting section explaining how to enable "Unattended mode" in the via the Tailscale tray icon. Tested on Windows 10, 22H2 with Tailscale 1.72.0 Replaces: juanfont#1995 See: juanfont#2096
* Simplify /windows to the bare minimum. Also remove the /windows/tailscale.reg endpoint as its generated file is no longer valid for current Tailscale versions. * Update and simplify the windows documentation accordingly. * Add a "Unattended mode" section to the troubleshooting section explaining how to enable "Unattended mode" in the via the Tailscale tray icon. * Add infobox about /windows to the docs Tested on Windows 10, 22H2 with Tailscale 1.72.0 Replaces: juanfont#1995 See: juanfont#2096
* Simplify /windows to the bare minimum. Also remove the /windows/tailscale.reg endpoint as its generated file is no longer valid for current Tailscale versions. * Update and simplify the windows documentation accordingly. * Add a "Unattended mode" section to the troubleshooting section explaining how to enable "Unattended mode" in the via the Tailscale tray icon. * Add infobox about /windows to the docs Tested on Windows 10, 22H2 with Tailscale 1.72.0 Replaces: juanfont#1995 See: juanfont#2096
* Simplify /windows to the bare minimum. Also remove the /windows/tailscale.reg endpoint as its generated file is no longer valid for current Tailscale versions. * Update and simplify the windows documentation accordingly. * Add a "Unattended mode" section to the troubleshooting section explaining how to enable "Unattended mode" in the via the Tailscale tray icon. * Add infobox about /windows to the docs Tested on Windows 10, 22H2 with Tailscale 1.72.0 Replaces: #1995 See: #2096
* Rename docs/ios-client.md to docs/apple-client.md. Add instructions for macOS; those are copied from the /apple endpoint and slightly modified. Fix doc links in the README. * Move infoboxes for /apple and /windows under the "Goal" section to the top. Those should be seen by users first as they contain *their* specific headscale URL. * Remove Tailscale versions hints * Mention /apple and /windows in the README along with their docs See: juanfont#2096
* Rename docs/ios-client.md to docs/apple-client.md. Add instructions for macOS; those are copied from the /apple endpoint and slightly modified. Fix doc links in the README. * Move infoboxes for /apple and /windows under the "Goal" section to the top. Those should be seen by users first as they contain *their* specific headscale URL. * Swap order of macOS and iOS to move "Profiles" further down. * Remove apple configuration profiles * Remove Tailscale versions hints * Mention /apple and /windows in the README along with their docs See: juanfont#2096
* Rename docs/ios-client.md to docs/apple-client.md. Add instructions for macOS; those are copied from the /apple endpoint and slightly modified. Fix doc links in the README. * Move infoboxes for /apple and /windows under the "Goal" section to the top. Those should be seen by users first as they contain *their* specific headscale URL. * Swap order of macOS and iOS to move "Profiles" further down. * Remove apple configuration profiles * Remove Tailscale versions hints * Mention /apple and /windows in the README along with their docs See: #2096
* Rename docs/ios-client.md to docs/apple-client.md. Add instructions for macOS; those are copied from the /apple endpoint and slightly modified. Fix doc links in the README. * Move infoboxes for /apple and /windows under the "Goal" section to the top. Those should be seen by users first as they contain *their* specific headscale URL. * Swap order of macOS and iOS to move "Profiles" further down. * Remove apple configuration profiles * Remove Tailscale versions hints * Mention /apple and /windows in the README along with their docs See: juanfont#2096
The goal is to update the documentation for the upcoming 0.23 release with minimal changes and (mostly) add one commit per file.
Other issues such as duplicate instructions in multiple files are not addressed as those require some discussions with the maintainers beforehand.
Fixes: #2090
Fixes: #1822
Summary by CodeRabbit
Summary by CodeRabbit
acl_policy_path
topolicy.path
, enhancing clarity for users.