Fix self notification on expiry update via oidc relogin

[mpoindexter]

• have read the CONTRIBUTING.md file
• raised a GitHub issue or discussed it on the projects chat beforehand
• added unit tests
• added integration tests
• updated documentation if needed
• updated CHANGELOG.md

Fixes #2079

Summary by CodeRabbit

• New Features
  • Enhanced notification system for node state updates, providing clearer contexts for self and peer notifications.
  • Introduced granular notifications that distinguish between self-update and peer notifications.

[coderabbitai]

Walkthrough

The changes primarily focus on enhancing the validateNodeForOIDCCallback function within the Headscale struct. Modifications include updating notification contexts to provide clearer information about node self-updates and peer notifications. New notification calls have been introduced, improving the granularity of state updates related to OIDC reauthentication processes.

Changes

Files	Change Summary
hscontrol/oidc.go	Updated notification contexts in validateNodeForOIDCCallback for clearer self-update and peer notifications. Added new notification calls to enhance state update granularity.

Assessment against linked issues

Objective	Addressed	Explanation
Reauthenticate updates key expiry after authentication (#2079)	❓	It's unclear if the changes fully resolve the key expiry update issue.

🐇 Hopping through the code, oh what a delight,
Notifications clearer, shining so bright!
Self-updates and peers, they now understand,
With each little change, our codebase expands!
A leap towards progress, let’s celebrate cheer,
In the world of OIDC, we’ll spread joy and good cheer! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9c4c286 and 5175832.

Files selected for processing (1)

• hscontrol/oidc.go (1 hunks)

Additional comments not posted (1)

hscontrol/oidc.go (1)

529-537: LGTM! Verify the new context strings and notification calls.

The changes improve the specificity of notifications related to node states. Ensure that the new context strings ("oidc-expiry-self" and "oidc-expiry-peers") and the new notification call to h.nodeNotifier.NotifyByNodeID are correctly implemented and do not introduce any issues.

The code changes are approved.

Run the following script to verify the new context strings and notification calls:

Verification successful

---

Verification successful for context strings and notification calls.

The context strings "oidc-expiry-self" and "oidc-expiry-peers" are correctly implemented in the hscontrol/oidc.go file. The NotifyByNodeID method is used appropriately across multiple files, indicating a consistent implementation of the notification system. No issues were found.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the new context strings and notification calls.

# Test: Search for the context strings. Expect: Only occurrences of the new context strings.
rg --type go -A 5 $'oidc-expiry-self'
rg --type go -A 5 $'oidc-expiry-peers'

# Test: Search for the notification calls. Expect: Only occurrences of the new notification calls.
rg --type go -A 5 $'h.nodeNotifier.NotifyByNodeID'

Length of output: 1565

[kradalby]

These failing tests should resolve after #2076, the fix is in one of the commits there.

[kradalby]

Rebasing this should make the test pass