Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1996): Implement register method enum converter #2013

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

rubenspeculis
Copy link
Contributor

Added a new function RegisterMethodToV1Enum() to Node, converting the internal register method string to the corresponding V1 Enum value. Included corresponding unit test in node_test.go to ensure correct conversion for various register methods.

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Added a new function `RegisterMethodToV1Enum()` to Node, converting the internal register method string to the corresponding V1 Enum value. Included corresponding unit test in `node_test.go` to ensure correct conversion for various register methods.
@kradalby
Copy link
Collaborator

Fixes #1996

@kradalby kradalby merged commit 00ff288 into juanfont:main Jul 17, 2024
103 checks passed
@rubenspeculis rubenspeculis deleted the issues/1996 branch July 18, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants