Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics, tuning in tests, db cleanups, fix concurrency issue #1895

Merged
merged 8 commits into from
Apr 21, 2024
Merged

metrics, tuning in tests, db cleanups, fix concurrency issue #1895

merged 8 commits into from
Apr 21, 2024

Conversation

kradalby
Copy link
Collaborator

@kradalby kradalby commented Apr 18, 2024 •
edited
Loading

  • adds WithTuning parameters to hsic and makes retry max wait into an argument for scenario
  • fix some logs that should be trace that was info
  • redo/add metrics for the new update model
  • reduce how long notifier hold locks (per node instead of all nodes)
  • use concurrency safe map for online status (could trigger racy panic), fixes Headscale crash with unknown cause #1862

Signed-off-by: Kristoffer Dalby [email protected]

kradalby added 5 commits April 19, 2024 11:31
@kradalby
add tuning and make timeout arg
3d98df7 
this commits add WithTuning parameters to hsic and makes retry max wait into an arguemnt for scenario

Signed-off-by: Kristoffer Dalby <[email protected]>
@kradalby
make chatty message trace
75b7fd7 
Signed-off-by: Kristoffer Dalby <[email protected]>
@kradalby
redo metrics
068a424 
Signed-off-by: Kristoffer Dalby <[email protected]>
@kradalby
lock notifier per node, not per update
6d5895d 
Signed-off-by: Kristoffer Dalby <[email protected]>
@kradalby
replace Transcations with Write
4e29109 
Signed-off-by: Kristoffer Dalby <[email protected]>
@kradalby kradalby force-pushed the integration-test-tuning branch from 61dfe61 to 4e29109 Compare April 19, 2024 09:32
@kradalby kradalby mentioned this pull request Apr 21, 2024
Closed
2 tasks
@kradalby kradalby force-pushed the integration-test-tuning branch from ec303b0 to 644d4d9 Compare April 21, 2024 08:05
@kradalby kradalby marked this pull request as ready for review April 21, 2024 08:06
@kradalby kradalby requested a review from juanfont as a code owner April 21, 2024 08:06
@kradalby kradalby changed the title add tuning and make timeout in integration test metrics, tuning in tests, db cleanups, fix concurrency issue Apr 21, 2024
@kradalby kradalby merged commit ba614a5 into juanfont:main Apr 21, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanfont juanfont juanfont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Headscale crash with unknown cause
2 participants
@kradalby @juanfont