-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use newer fork of termcolor #1853
Conversation
To make reviewing easier Original package: https://github.com/efekarakus/termcolor Replacement package: https://github.com/jagottsicher/termcolor Replacement package commit history and changes: efekarakus/termcolor@master...jagottsicher:termcolor:main Except for bugfix for Windows, it is only readmes and Go versions. It is the only fork, and there were no changes in the original repo after the fork: https://github.com/efekarakus/termcolor/network |
This could possible fix #1842. |
I used this same fork in another project. It is not ideal, as they are both abandoned... But I guess it is ok. |
the headscale go vendorHash in flake.nix needs to be updated:
Other failures looks a bit like gh actions was sad. |
Thank you, @kradalby, I've updated the branch. |
Rebase failed
@SergeAx can you rebase this branch to main again? We had a large PR entering... |
@juanfont done. |
You also need to update the flake.nix checksum to sha256-HGu/OCtjzPeBki5FSL6v1XivCJ30eqj9rL0x7ZVv1TM= Sorry for the mess... |
jagottsicher's fork fixed a bug in Windows implementation. While Windows may be not intended as a target platform, some contributors may prefer it for development. Also ran go mod tidy, thus two more unnecessary packages are removed from go.sum
No problem, done. |
Merged thanks! |
jagottsicher's fork fixed a bug in Windows implementation. While Windows may be not intended as a target platform, some contributors (yours truly included) may prefer it for development.
Also ran go mod tidy, thus three more unnecessary lines are removed from go.sum
Fixes #1842