Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer fork of termcolor #1853

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Use newer fork of termcolor #1853

merged 1 commit into from
Apr 16, 2024

Conversation

SergeAx
Copy link
Contributor

@SergeAx SergeAx commented Mar 30, 2024

jagottsicher's fork fixed a bug in Windows implementation. While Windows may be not intended as a target platform, some contributors (yours truly included) may prefer it for development.

Also ran go mod tidy, thus three more unnecessary lines are removed from go.sum

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #1842

@SergeAx SergeAx changed the title Use newer fork of termcolor (Fixes #1842) Use newer fork of termcolor Mar 31, 2024
@SergeAx
Copy link
Contributor Author

SergeAx commented Mar 31, 2024

To make reviewing easier

Original package: https://github.com/efekarakus/termcolor

Replacement package: https://github.com/jagottsicher/termcolor

Replacement package commit history and changes: efekarakus/termcolor@master...jagottsicher:termcolor:main

Except for bugfix for Windows, it is only readmes and Go versions.

It is the only fork, and there were no changes in the original repo after the fork: https://github.com/efekarakus/termcolor/network

@ohdearaugustin
Copy link
Collaborator

This could possible fix #1842.

@juanfont
Copy link
Owner

juanfont commented Apr 1, 2024

This could possible fix #1842.

I used this same fork in another project. It is not ideal, as they are both abandoned... But I guess it is ok.

@kradalby
Copy link
Collaborator

kradalby commented Apr 4, 2024

the headscale go vendorHash in flake.nix needs to be updated:

sha256-1xjTrDznPX7/UDT1RGZZxegm4bfYzC105VboDjZsWBg=

Other failures looks a bit like gh actions was sad.

@SergeAx
Copy link
Contributor Author

SergeAx commented Apr 5, 2024

the headscale go vendorHash in flake.nix needs to be updated:

sha256-1xjTrDznPX7/UDT1RGZZxegm4bfYzC105VboDjZsWBg=

Thank you, @kradalby, I've updated the branch.

@juanfont juanfont enabled auto-merge (rebase) April 11, 2024 12:12
auto-merge was automatically disabled April 11, 2024 14:22

Rebase failed

@juanfont
Copy link
Owner

@SergeAx can you rebase this branch to main again? We had a large PR entering...

@SergeAx
Copy link
Contributor Author

SergeAx commented Apr 16, 2024

@juanfont done.

@juanfont
Copy link
Owner

You also need to update the flake.nix checksum to sha256-HGu/OCtjzPeBki5FSL6v1XivCJ30eqj9rL0x7ZVv1TM=

Sorry for the mess...

jagottsicher's fork fixed a bug in Windows implementation. While Windows may be not intended as a target platform,
some contributors may prefer it for development.

Also ran go mod tidy, thus two more unnecessary packages are removed from go.sum
@SergeAx
Copy link
Contributor Author

SergeAx commented Apr 16, 2024

No problem, done.

@juanfont juanfont merged commit 85cef84 into juanfont:main Apr 16, 2024
100 checks passed
@juanfont
Copy link
Owner

Merged thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building error!
4 participants