Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add docs for running headscale on sealos #1666

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

yangchuansheng
Copy link
Contributor

@yangchuansheng yangchuansheng commented Dec 28, 2023

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Copy link
Collaborator

@ohdearaugustin ohdearaugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally well written documentation. Just added some minor suggestions.

docs/running-headscale-sealos.md Show resolved Hide resolved
docs/running-headscale-sealos.md Outdated Show resolved Hide resolved
docs/running-headscale-sealos.md Outdated Show resolved Hide resolved
docs/running-headscale-sealos.md Outdated Show resolved Hide resolved
@kradalby
Copy link
Collaborator

I'm sceptical to having to specific documentation for niche distributions, but if it is community maintained, I suppose it might be fine.

What do you think @ohdearaugustin ?

@ohdearaugustin
Copy link
Collaborator

I think the same. I already asked to changes some things, therefore with disclaimer I don't see any problem with it.

@ohdearaugustin
Copy link
Collaborator

@yangchuansheng would you please fix the suggestion otherwise I will close the PR.

@yangchuansheng
Copy link
Contributor Author

yangchuansheng commented Apr 10, 2024

@yangchuansheng would you please fix the suggestion otherwise I will close the PR.

Ok, I'll fix the suggestion soon, Thank you for reviewing my pull request and providing valuable feedback.

@yangchuansheng yangchuansheng force-pushed the dev branch 2 times, most recently from 4aa98c0 to bd16ed5 Compare April 10, 2024 08:34
@yangchuansheng
Copy link
Contributor Author

@yangchuansheng would you please fix the suggestion otherwise I will close the PR.

done! Please kindly review the modifications and let me know if there's anything else that needs to be addressed or if you have any further suggestions.

Copy link
Collaborator

@ohdearaugustin ohdearaugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes, mainly wording

docs/running-headscale-sealos.md Outdated Show resolved Hide resolved
docs/running-headscale-sealos.md Outdated Show resolved Hide resolved
docs/running-headscale-sealos.md Outdated Show resolved Hide resolved
docs/running-headscale-sealos.md Outdated Show resolved Hide resolved
@ohdearaugustin ohdearaugustin self-assigned this Apr 11, 2024
@yangchuansheng
Copy link
Contributor Author

Small changes, mainly wording

Done.

@yangchuansheng
Copy link
Contributor Author

Please let me know if there's anything else I should work on or if you have any further feedback, thanks.

@ohdearaugustin ohdearaugustin merged commit d6ec31c into juanfont:main Apr 21, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants