-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add docs for running headscale on sealos #1666
Conversation
yangchuansheng
commented
Dec 28, 2023
•
edited
Loading
edited
- read the CONTRIBUTING guidelines
- raised a GitHub issue or discussed it on the projects chat beforehand
- added unit tests
- added integration tests
- updated documentation if needed
- updated CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally well written documentation. Just added some minor suggestions.
I'm sceptical to having to specific documentation for niche distributions, but if it is community maintained, I suppose it might be fine. What do you think @ohdearaugustin ? |
I think the same. I already asked to changes some things, therefore with disclaimer I don't see any problem with it. |
@yangchuansheng would you please fix the suggestion otherwise I will close the PR. |
Ok, I'll fix the suggestion soon, Thank you for reviewing my pull request and providing valuable feedback. |
4aa98c0
to
bd16ed5
Compare
done! Please kindly review the modifications and let me know if there's anything else that needs to be addressed or if you have any further suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes, mainly wording
Signed-off-by: Carson Yang <[email protected]>
Done. |
Please let me know if there's anything else I should work on or if you have any further feedback, thanks. |