Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync errorgroup handling in integration tests #1460

Conversation

kev-the-dev
Copy link

@kev-the-dev kev-the-dev commented May 11, 2023

Address TODOs in integration tests to handle errors from sync WaitGroup for things like bringing up a bunch of tailscale nodes. I ran into some confusing segfaults when running integration tests locally that would be helped by implementing this fail-on-error rather than log-on-error.

Closes #1459

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md -> internal change, no changelog update

@kradalby kradalby force-pushed the kev-the-dev/integration-test-error-handeling branch from 3047fe4 to 39accdc Compare May 12, 2023 09:38
@kev-the-dev
Copy link
Author

will wait to rebase and advance until after the reorg #1473

kradalby added a commit to kradalby/headscale that referenced this pull request Aug 29, 2023
kradalby added a commit to kradalby/headscale that referenced this pull request Aug 29, 2023
kradalby added a commit to kradalby/headscale that referenced this pull request Aug 29, 2023
kradalby added a commit to kradalby/headscale that referenced this pull request Aug 29, 2023
kradalby added a commit to kradalby/headscale that referenced this pull request Aug 29, 2023
kradalby added a commit to kradalby/headscale that referenced this pull request Aug 29, 2023
kradalby added a commit to kradalby/headscale that referenced this pull request Aug 29, 2023
kradalby added a commit to kradalby/headscale that referenced this pull request Aug 29, 2023
kradalby added a commit to kradalby/headscale that referenced this pull request Sep 2, 2023
kradalby added a commit that referenced this pull request Sep 5, 2023
Thanks @kev-the-dev

Closes #1460

Signed-off-by: Kristoffer Dalby <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch sync group errors in integration tests
1 participant