Update docker related doc #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Milokita
commented
May 5, 2023
•
Milokita
commented
- read the CONTRIBUTING guidelines
- raised a GitHub issue or discussed it on the projects chat beforehand
- added unit tests
- added integration tests
- updated documentation if needed
- updated CHANGELOG.md
without changing the unix socket location, the docker container will fail to launch and gives error `FTL go/src/headscale/cmd/headscale/cli/server.go:26 > Error starting server error="failed to set up gRPC socket: listen unix /var/run/headscale/headscale.sock: bind: no such file or directory"`
There was a problem hiding this comment.
We should first resolve #1417 and then see how we will do it.
docs/running-headscale-container.md
Outdated
| @@ -66,6 +66,8 @@ db_type: sqlite3 | |||
| db_path: /etc/headscale/db.sqlite | |||
| ``` | |||
|
|
|||
| Change the `unix_socket: /var/run/headscale/headscale.sock` to `unix_socket: ./headscale.sock` for gRPC socket if you encounter `Error starting server error="failed to set up gRPC socket` related error | |||
There was a problem hiding this comment.
This is currently discussed in #1417
There was a problem hiding this comment.
Maybe we should introduce it as a temporarily fix for docker users?
There was a problem hiding this comment.
This is now obsolete due to #1450.
There was a problem hiding this comment.
Yep, I have already removed this section
f2dfe5b
ohdearaugustin
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.