optimize generateACLPeerCacheMap #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy to get this in if the tests pass, the whole thing need to be rewritten, so elegancy is not my big concern atm. Please also remove |
|
Hi, the expandACLPeerAddr function is still used in line 170. |
|
Added this patch into the RPMs in 0.22.1-2. jonathanspw/headscale-rpm@02a711b https://copr.fedorainfracloud.org/coprs/jonathanspw/headscale/build/5850042/ |
|
I've tested both the proposed changes and @jonathanspw RPM. This seems to resolve this issue. |
kradalby
approved these changes
Apr 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is a possible optimization for the problem in issue #1372.
Not the most elegant solution but it should work.