Added an OIDC AllowGroups option for authorization. #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks reasonable, can you add a CHANGELOG.md entry? |
newellz2
force-pushed
the
main
branch
2 times, most recently
from
672b2a6
to
6db4263
Compare
|
@kradalby I added a CHANGELOG.md entry. Let me know if I need to do anything else! |
kradalby
reviewed
Dec 6, 2022
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| ### Changes | |||
|
|
|||
| - Added an OIDC AllowGroups Configuration options and authorization check [#1041](https://github.com/juanfont/headscale/pull/1041) | |||
There was a problem hiding this comment.
Good, could you just move it up to 0.18.x?
There was a problem hiding this comment.
You got it! I just amended the commit.
kradalby
approved these changes
Dec 7, 2022
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an additional OIDC configuration option for a 'groups' claim. The allowed_groups config option is another OIDC authorization option. I tested this with Keycloak by adding a group membership client scope to the OIDC provider.