Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in function excludeCorrectlyTaggedNodes() #563

Closed
awsong opened this issue Apr 28, 2022 · 2 comments · Fixed by #707
Closed

bug in function excludeCorrectlyTaggedNodes() #563

awsong opened this issue Apr 28, 2022 · 2 comments · Fixed by #707

Comments

@awsong
Copy link

awsong commented Apr 28, 2022

In function excludeCorrectlyTaggedNodes() when matching tags with tagOwners:

for tag, ns := range aclPolicy.TagOwners {

The above line missing the condition when tagOwners are groups.
Adding two lines here could fix this problem
owners, _ := expandTagOwners(aclPolicy, namespace, true)
ns = append(owners, namespace)
But the third parameter (true/false) needs to be filled correctly, which I'm not sure how could be elegantly done.

@kradalby
Copy link
Collaborator

We will be grateful for a PR to solve this issue :)

@restanrm, does this look right to you? Maybe this is already fixed?

@restanrm
Copy link
Contributor

I'll check this as soon as I found some time to do it.

restanrm added a commit to restanrm/headscale that referenced this issue Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants