Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Inconsistency ‘givenName’ in node #2177

Closed
2 of 4 tasks
hopleus opened this issue Oct 7, 2024 · 0 comments · Fixed by #2198
Closed
2 of 4 tasks

[Bug] Inconsistency ‘givenName’ in node #2177

hopleus opened this issue Oct 7, 2024 · 0 comments · Fixed by #2198
Labels
bug Something isn't working
Milestone

Comments

@hopleus
Copy link
Contributor

hopleus commented Oct 7, 2024

Is this a support request?

  • This is not a support request

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Host name where the error occurs - MacBook-Pro
(This is the real hostname of my machine)

When registering a node on the network, hostname as well as givenName is stored in its original form from tailcfg.Hostname - MacBook-Pro, without making it based on FQDN rules.
When renaming a node (changing the givenName), the logic checks the new name for FQDN compliance (CheckForFQDNRules) and does not allow the MacBook-Pro name to be saved, requiring lowercase i.e. macbook-pro.

Expected Behavior

When a node is registered on the network, the givenName is stored subject to FQDN rules.

Steps To Reproduce

  1. Register node
  2. Show givenName in DB
  3. Try changing the node name to the same
  4. Receive an FQDN error
  5. Save the new node name taking into account the FQDN rules
  6. It's OK, the new name is saved

Environment

- OS: MacOS 15
- Headscale version: 0.22.3
- Tailscale version: 1.74.0

Runtime environment

  • Headscale is behind a (reverse) proxy
  • Headscale runs in a container

Anything else?

No response

@hopleus hopleus added the bug Something isn't working label Oct 7, 2024
hopleus added a commit to hopleus/headscale that referenced this issue Oct 9, 2024
hopleus added a commit to hopleus/headscale that referenced this issue Oct 9, 2024
hopleus added a commit to hopleus/headscale that referenced this issue Oct 15, 2024
hopleus added a commit to hopleus/headscale that referenced this issue Oct 15, 2024
hopleus added a commit to hopleus/headscale that referenced this issue Oct 15, 2024
kradalby pushed a commit that referenced this issue Oct 15, 2024
@nblock nblock added this to the v0.24.0 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants