Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: -skip parameter not properly used #30

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

clemcvlcs
Copy link
Contributor

The -skip should pass a comma separated list of Kinds to be skipped.

The parameter was passing nothing, and so was not used.

Tested with
helm kubeconform mychart --skip "Middleware"

Before this fix, the same command returned :

$ helm kubeconform mychart  --skip "Middleware"
ERROR: Testing failed: kubeconform failed: failed to run kubeconform: rc=1
stdin - Middleware whitelist-kubeconform-main is invalid: problem validating schema. Check JSON formatting: jsonschema: '/spec' does not validate with https://raw.githubusercontent.com/datreeio/CRDs-catalog/main/traefik.io/middleware_v1alpha1.json#/properties/spec/additionalProperties: additionalProperties 'ipAllowList' not allowed
Error: plugin "kubeconform" exited with error

@clemcvlcs
Copy link
Contributor Author

Hi @jtyr ,
Can you have a quick look to this PR please ?

@jtyr jtyr merged commit bfd3332 into jtyr:main Mar 11, 2024
2 checks passed
@jtyr
Copy link
Owner

jtyr commented Mar 11, 2024

Thanks for your contribution, @clemcvlcs! ❤️

@clemcvlcs
Copy link
Contributor Author

thanks @jtyr ,
It seems that the github token you're using to perform the tagging for every merged PR has expired, can you have a look ? 🙏

@jtyr
Copy link
Owner

jtyr commented Mar 11, 2024

I don;t know why it stopped working now. It used to work just fine. I have pushed the tag manually for not and I will have a look at the automation later 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants