Loosen conversion budget for unquoted-safe arrays. #907
+13
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #906 The buffer budget calculation for arrays of unquoted-safe types was slightly too tight. I think I've had to fix this for unsafe types in the past.
jtv
force-pushed
the
906-increase-array-budget
branch
from
5bcdc14
to
5bf90de
Compare
Prior to C++17 you couldn't just compare two `string_view`s for equality. So I had a function to work around that. We now require a more modern C++, so we can drop that function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #906
The buffer budget calculation for arrays of unquoted-safe types was slightly too tight. I think I've had to fix this for unsafe types in the past.