WIP: Replace errorhandler mechanism.
#903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecating `errorhandler`. The whole mechanism is outdated and clunky and also horribly _broken_ when a handler survives its `connection`. Turns out `PGresult` keeps a pointer to the same handler that the `PGconn` had, so it can still send notices even after you've closed the connection. Trying to fix this with the existing mechanism would still break the ABI. (At least without infernal and probably non-portable trickery.) Instead of modernising the whole mechanism, I'm also simplifying it. I doubt many people will need _chains_ of handlers, with the option for handlers to request bypassing of the following handlers. And for those rare cases where that's useful, it's probably easier for the application to implement the call chain itself!
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Had to make it a `shared_ptr`. But now I guess I'll need to register a deleter on it to get the cleanup right.
jtv
changed the title
errorhandler mechanism.errorhandler mechanism.
|
|
||
| namespace | ||
| { | ||
| void test_notice_handler_receives_notice() |
Check notice
Code scanning / CodeQL
Unused static function Note test
| } | ||
|
|
||
|
|
||
| void test_process_notice_calls_notice_handler() |
Check notice
Code scanning / CodeQL
Unused static function Note test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecating
errorhandler. The whole mechanism is outdated and clunkyand also horribly broken when a handler survives its
connection.Turns out
PGresultkeeps a pointer to the same handler that thePGconnhad, so it can still send notices even after you've closed theconnection.
Trying to fix this with the existing mechanism would still break the
ABI. (At least without infernal and probably non-portable trickery.)
So this is more than a "patch-level" version bump.
Instead of modernising the whole mechanism, I'm also simplifying it.
I doubt many people will need chains of handlers, with the option
for handlers to request bypassing of the following handlers. And for
those rare cases where that's useful, it's probably easier for the
application to implement the call chain itself!