Address review comments

jtung-apple · May 6, 2024 · 6356cbe · 6356cbe
1 parent 446f1e0
commit 6356cbe
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/darwin/Framework/CHIPTests/MTRAsyncWorkQueueTests.m b/src/darwin/Framework/CHIPTests/MTRAsyncWorkQueueTests.m
@@ -508,10 +508,12 @@ - (void)testItemsConcurrently
         }
         os_unfair_lock_unlock(&counterLock);
         sleep(1);
+        os_unfair_lock_lock(&counterLock);
         afterSleepCounter++;
         if (afterSleepCounter == 3) {
             [first3WorkItemsSleptExpectation fulfill];
         }
+        os_unfair_lock_unlock(&counterLock);
         completion(MTRAsyncWorkComplete);
     };
 
@@ -533,9 +535,8 @@ - (void)testItemsConcurrently
     workItemLast.readyHandler = ^(id context, NSInteger retryCount, MTRAsyncWorkCompletionBlock completion) {
         // expect this to have waited until at least one of the above items finished after sleep() and incremented counter
         os_unfair_lock_lock(&counterLock);
-        if (afterSleepCounter > 0) {
-            [lastWorkItemWaitedExpectation fulfill];
-        }
+        XCTAssert(afterSleepCounter > 0);
+        [lastWorkItemWaitedExpectation fulfill];
         os_unfair_lock_unlock(&counterLock);
         completion(MTRAsyncWorkComplete);
     };