[Darwin] Fix MTRDeviceConnectivityMonitor DNSServiceRefDeallocate cal…

…l on the correct queue
jtung-apple · May 12, 2024 · 45f2993 · 45f2993
1 parent d1d0d2b
commit 45f2993
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/darwin/Framework/CHIP/MTRDeviceConnectivityMonitor.mm b/src/darwin/Framework/CHIP/MTRDeviceConnectivityMonitor.mm
@@ -264,8 +264,11 @@ - (void)_stopMonitoring
 
 - (void)stopMonitoring
 {
-    MTR_LOG_INFO("%@ stop connectivity monitoring for %@", self, _instanceName);
-    std::lock_guard lock(sConnectivityMonitorLock);
-    [self _stopMonitoring];
+    // DNSServiceRefDeallocate must be called on the same queue set on the shared connection.
+    dispatch_async(sSharedResolverQueue, ^{
+        MTR_LOG_INFO("%@ stop connectivity monitoring for %@", self, self->_instanceName);
+        std::lock_guard lock(sConnectivityMonitorLock);
+        [self _stopMonitoring];
+    });
 }
 @end