Skip to content

Commit

Permalink
[Fix] Possible fix for matter-test-scripts issue #227: Remove PICS fr…
Browse files Browse the repository at this point in the history
…om OPSTATE tests (project-chip#34290)

* Possible fix for matter-test-scripts issue #227:
- Removed PICS checks and replaced with attribute and command checks from endpoint during tests.

* Restyled by autopep8

* Updated TC_OpstateCommon.py:
- Removed some variables that were no longer needed

* Updated TC_RVCOPSTATE_2_1 test module:
- Removed automatable PICS checks and replaced with attributes available to be gathered from endpoint.

* Restyled by autopep8

* Restyled by isort

* Updated TC_RVCOPSTATE_2_1 test module:
- Adding back in missing time import and test runner comments into test module

* Updated TC_RVCOPSTATE_2_1 test module:
- Replaced input() with wait_for_user_input() in test script
- Added back in short sleep to script, not sure why it got removed.

* Resolving Linting issue in TC_RVCOPSTATE_2_1:
- Had to remove "test_step" variable that was attempting to be called in wait_for_user_input() as it was not being defined earlier in the test module.

* Updating TC_RVCOPSTATE_2_1 test module:
- Minor change to remove unneeded f-string from wait_for_user_input().

* Updated TC_RVCOPSTATE_2_1 test module:
- Re-imported the test_step variable for test steps 6 and 7 manual testing that were accidentally removed
- Re-imported the variable being called in the self.wait_for_user_input()

* Updated TC_RVCOPSTATE_2_1 test module:
- Replaced missing test_step variable and calls for it in self.wait_for_user_input()

* Restyled by autopep8

* Updated TC_OpstateCommon and TC_RVCOPSTATE_2_1:
- Removed oprtnlstate_attr_id variable and if statements as it is a mandatory attribute.
- Created new common functions in OpstateCommon test module to create dictionary containing attributes and commands.
- Renamed some variables that had upper case letters to contain only lower case letters.
- Removed creating variable for events and returned PICS checks for those in TC_OpstateCommon test module as not currently able to automate

* Restyled by autopep8

* Updated TC_OpstateCommon module:
- Removed unneeded local variable "phase_list_attr_id" as lint mentioned it is not being used in test 2_3.

* Updated TC_OpstateCommon and TC_RVCOPSTATE_2_1:
- Removed variable functions and replaced with calling named attributes in if checks directly.

* Restyled by autopep8

* Updated matter_testing_support, OpstateCommon, and RVCOPSTATE_2_1 modules:
- Added attributes_guard to matter_testing_support helper module to check if attributes are in attributes list using has_attributes function
- Changed attributes checks to using attributes_guard function in OpstateCommon and RVCOPSTATE_2_1 test modules

* Restyled by autopep8

* Restyled by isort

* Updated TC_OpstateCommon.py:
- Resolved linting errors

* Updating method for attributes_guard functionality

* Updated TC_RVCOPSTATE_2_1 test module:
- Debugging to find issue why test is failing in CI pipeline.

* Updating TC_RVCOPSTATE_2_1 test module:
- Continuing effort to resolve issue with CI pipeline

* Updated TC_OpstateCommon, TC_RVCOPSTATE_2_1, and matter_testing support:
- Resolved issues with attributes_guard function in matter_testing support module

* Restyled by autopep8

* Updated TC_RVCOPSTATE_2_1 test module:
- changed verbosity in CI arguments to make it quieter.

* Updating matter_testing support module:
- Updated attributes_guard function to make it async

* Updating TC_OpstateCommon and TC_RVCOPSTATE_2_1 test modules:
- Updated method for attributes_guard functionality.
- Added additional check to make sure that endpoint is not 0 or not provided in command line

* Restyled by autopep8

* Updated matter_testing helper module:
- Resolved linting error

* Updating TC_RVCOPSTATE_2_1 test module:
- Resolving linting error

* Update src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py

Adding coding change from Cecille!

Co-authored-by: C Freeman <[email protected]>

* Updating OPSTATECommon and RVCOPSTATE_2_1 modules:
- Updated to using attribute_guard function in place of attributes_guard.

* Updated matter_testing, added new TC_TestAttrAvail modules:
- Updated matter_testing support module to include new command_guard() and feature_guard()
- Created standalone test to show that guard functionality works for CASE, PASE, and no factory reset commissioning
- Added TC_TestAttrAvail to slow tests as it takes ~30 seconds to run the tests

* Restyled by autopep8

* Restyled by isort

* Updated TC_OpstateCommon python module:
- Updated to using new command_guard() for OPSTATE tests

* Updated matter_testing, TC_OpstateCommon, and TC_TestAttrAvail modules:
- Resolving linting errors

* Restyled by isort

* Update src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py

Adding commi from Cecille to the code here to help better clarify and explain reasoning for this coding change.

Co-authored-by: C Freeman <[email protected]>

---------

Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: C Freeman <[email protected]>
  • Loading branch information
3 people authored Dec 16, 2024
1 parent 43f66f0 commit 33dda32
Show file tree
Hide file tree
Showing 5 changed files with 433 additions and 185 deletions.
Loading

0 comments on commit 33dda32

Please sign in to comment.