Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): use osc_to_u16 even without read scancode #1321

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Conversation

jtroo
Copy link
Owner

@jtroo jtroo commented Nov 2, 2024

Describe your changes. Use imperative present tense.

This fixes an issue where keypad enter was not working correctly. I'm not entirely sure why the conditional compile branch was written in the first place; maybe I defaulted to it without thinking much about it. But it seems correct to use osc_to_u16 regardless of llhook reading mechanism given that output VK doesn't care about input reading mode.

Checklist

  • Add documentation to docs/config.adoc
    • N/A
  • Add example and basic docs to cfg_samples/kanata.kbd
    • N/A
  • Update error messages
    • N/A
  • Added tests, or did manual testing
    • Yes

This fixes an issue where keypad enter was not working correctly. I'm
not entirely sure why the conditional compile branch was written in the
first place; maybe I defaulted to it without thinking much about it. But
it seems correct to use osc_to_u16 regardless of llhook reading
mechanism given that output VK doesn't care about input reading mode.
@jtroo jtroo merged commit fab0d89 into main Nov 2, 2024
4 checks passed
@jtroo jtroo deleted the winkprt branch November 2, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant